USWDS - Place-Icon() defaults & WHC themes for Accordion, Banner, Search, and Header#4604
Merged
Merged
Conversation
added 6 commits
March 24, 2022 15:28
mejiaj
suggested changes
Mar 25, 2022
Contributor
There was a problem hiding this comment.
Nice changes! Just a few minor things.
Please make sure you delete any commented code before PR.
The banner text Here's how you know is one color on mobile and another on desktop. Let's make it consistent.
Banner_.Default._.U.S.Web.Design.System.v2.13.2.and.2.more.pages.-.Work.-.Microsoft.Edge.Beta.2022-03-25.11-21-21.mp4
mejiaj
approved these changes
Mar 25, 2022
mejiaj
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks Charlie!
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previews:
Accordion →
Banner →
Search →
Header →
Description
Previous WHC work caused conflicting styles due to the scope of the accordion component. To avoid this we set Accordion
forced-color-adjust: nonewhich allowed us to keep the standard styles that are already color contrast compliant.This PR also sets defaults for the
place-icon()function for easier implementation and less redundancy in the code.Accordion
Accordion was missing the icons which implied there was collapsed content hidden.
Current High Contrast / High Contrast Fix: Dark Theme / High Contrast Fix: Light Theme
Banner
The banner was missing chevrons, which implies there is content hidden behind the link. It was also missing the close icon on mobile which allows users to close the pane.
Current High Contrast / High Contrast FIx
Search
The search component was missing the button outline as well as the magnifying glass icon in high contrast modes.
Current High Contrast / High Contrast Fix
Header
The header would be missing chevrons, mobile open and close buttons, and the search button depending on theme color
Mobile
Include any of the following (as necessary):
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.