Skip to content

Beta - Repair template data issue#4564

Merged
mejiaj merged 13 commits intolibrary--developfrom
al-ld-template-repair
Mar 10, 2022
Merged

Beta - Repair template data issue#4564
mejiaj merged 13 commits intolibrary--developfrom
al-ld-template-repair

Conversation

@amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Mar 7, 2022

Description

This PR resolves the data and accessibility errors found in the html-templates build. These errors prevented a successful build on USWDS-site. With these updates, we should now be able to run npm run build:html with no errors and complete integration on Site.

Tasks completed

  • Fix usa-base data
    • Revert template elements (banner, identifier, header, footer, skipnav) to declare settings via twig includes instead of JSON; remove JSON references for these elements from template stories
  • Add default values to usa-sign-in-form and usa-password via twig
  • Update Snyk
    • Update Snyk to match develop branch
  • Resolve accessibility issue on Pagination component
    • update aria-label values to prevent aria duplicate landmark error
  • Add image paths and language settings

@amyleadem amyleadem marked this pull request as ready for review March 9, 2022 00:45
@amyleadem amyleadem requested a review from mejiaj March 9, 2022 00:45
@mejiaj mejiaj merged commit fd039de into library--develop Mar 10, 2022
@mejiaj mejiaj deleted the al-ld-template-repair branch March 10, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants