USWDS - Add package exports for fonts and img src directories#4468
Merged
thisisdano merged 1 commit intoJan 19, 2022
Merged
Conversation
Contributor
|
Our next release will feature the following new exports: Would this work for your project? |
Contributor
Author
Unfortunately no, I encountered the same errors with those exports |
thisisdano
approved these changes
Jan 19, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USWDS - Add package exports for fonts and img src directories
Description
After upgrading our project that uses USWDS to react-scripts v5.0.0 which uses Webpack 5. The following errors surfaced when trying to build our app
ModuleNotFoundError: Module not found: Error: Package path ./src/fonts/roboto-mono/roboto-mono-v5-latin-300.woff2 is not exported from package /Users/pearl/Projects/mymove/node_modules/uswds (see exports field in /Users/pearl/Projects/mymove/node_modules/uswds/package.json)and
ModuleNotFoundError: Module not found: Error: Package path ./src/img/correct8.svg is not exported from package /Users/pearl/Projects/mymove/node_modules/uswds (see exports field in /Users/pearl/Projects/mymove/node_modules/uswds/package.json)The changes in this PR resolves both issues