USCIS: Export other artifacts#4461
Merged
Merged
Conversation
Webpack 5 enforces correct export rules and thus prevents importing things like uswds.css.
thisisdano
approved these changes
Jan 16, 2022
Contributor
|
This looks good to me. @mejiaj can you confirm? |
Merged
scottqueen-bixal
approved these changes
Jan 18, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webpack 5 enforces correct export rules and thus prevents importing things like uswds.css.
Description
Upgrading to webpack 5 in our project caused our import of the css to break. The proposed change allows us to continue using this project without a fork/hack/or holding back a webpack upgrade.
Additional information
I don't have the webpack change on hand, but if I run across it again i'll update this ticket.
npm testand make sure the tests for the files you have changed have passed.