Skip to content

USWDS - Datepicker: Fix regression causing issues for Safari.#4456

Merged
thisisdano merged 2 commits into
developfrom
jm-safari-datepicker
Jan 16, 2022
Merged

USWDS - Datepicker: Fix regression causing issues for Safari.#4456
thisisdano merged 2 commits into
developfrom
jm-safari-datepicker

Conversation

@mejiaj

@mejiaj mejiaj commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

Description

Fixed Date Picker selection in Safari. Date selection now works as expected in Safari. Closes #4446.

Additional information

Newly generated Calendar date table was being placed as a sibling of usa-date-picker__calendar__date-picker, instead of being a child element.

Expected markup

<div tabindex="-1" class="usa-date-picker__calendar__date-picker">
  <div class="usa-date-picker__calendar__row"></div>
  <table class="usa-date-picker__calendar__table" role="presentation"></table>
</div>

Actual

<div tabindex="-1" class="usa-date-picker__calendar__date-picker">
  <div class="usa-date-picker__calendar__row"></div>
</div>
<table class="usa-date-picker__calendar__table" role="presentation"></table>

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

James Mejia added 2 commits January 10, 2022 16:12
- Revert `focusout` event listener on `DATE_PICKER`
- Place newly generated date calendar in correct spot (was a sibling of datepicker instead of child)
@mejiaj mejiaj changed the title USWDS - Datepicker: Update logic to toggle datepicker on focusOut. USWDS - Datepicker: Fix regression causing issues for Safari. Jan 14, 2022
@mejiaj mejiaj marked this pull request as ready for review January 14, 2022 15:00
@thisisdano

Copy link
Copy Markdown
Contributor

Preview

@thisisdano

Copy link
Copy Markdown
Contributor

Superior sleuthing. Bravo. 👏👏👏

@thisisdano thisisdano merged commit 2ddbf8c into develop Jan 16, 2022
@thisisdano thisisdano deleted the jm-safari-datepicker branch January 16, 2022 06:36
This was referenced Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Date picker doesn't work on Safari

2 participants