Skip to content

Update notifications#4426

Merged
thisisdano merged 3 commits into
developfrom
dw-update-notifications
Dec 14, 2021
Merged

Update notifications#4426
thisisdano merged 3 commits into
developfrom
dw-update-notifications

Conversation

@thisisdano

Copy link
Copy Markdown
Contributor

See comments

+ "\A usa-combo-box components."
+ "\A - We updated our guidance and code for numeric fields to use `text`"
+ "\A rather than `number` inputs with an `inputmode` of `numeric`."
+ "\A 2.0.2: We changed the names of some settings and mixins."

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the order here to chronological from reverse-chronological so the most current notification is at the bottom. This means that the most current notification is visible in the terminal window when the compile completes and users don't have to scroll up to see the most current notification

Comment on lines +127 to +137
+ "\A 2.13.0:"
+ "\A BREAKING CHANGES:"
+ "\A - We made a couple breaking changes to support the accessibility"
+ "\A of icon-only buttons. See complete release notes:"
+ "\A https://github.com/uswds/uswds/releases/tag/v2.13.0"
+ "\A - We updated markup in the small Search button to include the "
+ "\A magnifying glass as an inline image instead of a background image."
+ "\A See the release notes for the updated markup."
+ "\A - We updated the social icons in the Footer to use inline images "
+ "\A instead of a background images."
+ "\A See the release notes for the updated markup.";

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the 2.13.0 notes. We really want to call out that there are a couple breaking changes and direct folks to the release notes for update markup.

The link to the release notes is not yet active, but will be after the release.

Comment on lines +127 to +138
+ "\A 2.13.0:"
+ "\A BREAKING CHANGES:"
+ "\A - We made a couple breaking changes to support the accessibility"
+ "\A of icon-only buttons. See complete release notes:"
+ "\A https://github.com/uswds/uswds/releases/tag/v2.13.0"
+ "\A - We updated the markup of the small Search button to include its "
+ "\A magnifying glass icon as an inline image instead of as a "
+ "\A background image."
+ "\A See the release notes for the updated markup."
+ "\A - We updated the markup of the social icons in the Footer "
+ "\A to use inline images instead of background images."
+ "\A See the release notes for the updated markup.";

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the 2.13.0 notifications. We're highlighting the breaking changes and pointing users to the release notes for the markup updates. The release notes link will not be active until we publish the release.

@thisisdano thisisdano merged commit aa6830d into develop Dec 14, 2021
@thisisdano thisisdano deleted the dw-update-notifications branch December 14, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants