File upload: Confirm file upload to screenreaders.#4415
Merged
Conversation
thisisdano
approved these changes
Dec 9, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preview →
File upload confirms files to screenreaders. Closes #4232. Now file input will tell screenreaders how many files were uploaded and their names on upload.
Additional information
Based off of Amy's work in #4406. By default the file input will say
No file(s) uploaded. And on file upload it will change toYou have selected {{ NUMBER_OF_FILES }} files: {{ FILES_LISTED }}. When a user clears files, it'll go back to the default message.Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.