Skip to content

Dependencies: Move del to devDependencies#4349

Merged
thisisdano merged 1 commit into
uswds:developfrom
aduth:aduth-del-dev-dependency
Oct 25, 2021
Merged

Dependencies: Move del to devDependencies#4349
thisisdano merged 1 commit into
uswds:developfrom
aduth:aduth-del-dev-dependency

Conversation

@aduth

@aduth aduth commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

Description

This pull request seeks to update package dependencies to list del as a devDependencies, not as a dependencies.

Additional information

del is only used for Gulp build (build.js and release.js), so it doesn't need to be installed by downstream consumers. By listing del as a devDependencies, this prevents it from being installed during npm install in a consuming project, thus making for a smaller / faster installation. It also helps keep a clearer distinction between dependencies USWDS uses at runtime vs. for development.


Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

Because it's only used for build

@mejiaj mejiaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants