Update success-dark to vivid variant#4183
Merged
thisisdano merged 2 commits intouswds:developfrom May 24, 2021
Merged
Conversation
success-dark to vivid variant
mejiaj
suggested changes
May 14, 2021
Contributor
There was a problem hiding this comment.
Value also needs to be updated on src/stylesheets/theme/_uswds-theme-color.scss.
CC @thisisdano
We might also want to change the darker value to green-cool-60v to match.
Otherwise it'd look like:
Contributor
Author
mejiaj
approved these changes
May 15, 2021
thisisdano
approved these changes
May 24, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for light text on a
successbackground, for example: status tags. The current one is drab and doesn't look like a state color and this is more similar to thesuccesstoken.Brought up in Slack in 2019