Skip to content

USWDS - Build: Modify build tasks to get more reliable output on release.#4074

Merged
thisisdano merged 9 commits into
developfrom
jm-release-task-update
Mar 11, 2021
Merged

USWDS - Build: Modify build tasks to get more reliable output on release.#4074
thisisdano merged 9 commits into
developfrom
jm-release-task-update

Conversation

@mejiaj

@mejiaj mejiaj commented Mar 5, 2021

Copy link
Copy Markdown
Contributor

Description

Resolves #4072. The task make-tmp-directory in release.js was being started before build task was finished. This resulted in incomplete ZIP files of release builds.

  • Modifies tasks insvg-sprite.js so the streams are returned after they finish
  • Adds svg-sprite as parallel task

Additional information

Steps to test:

  • Pull branch
  • Run npx gulp release
  • Verify contents of ZIP file, specifically scss/utilities/palettes as well as img/ and img/usa-icons
    Previously, builds looked successful but img directory would be empty or more nested SCSS folders would be empty. Aside from JS directory being missing.

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj mejiaj marked this pull request as ready for review March 5, 2021 18:59
@mejiaj mejiaj requested a review from thisisdano March 5, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

USWDS - Build: Release task isn't building reliably.

2 participants