USWDS - Build: Modify build tasks to get more reliable output on release.#4074
Merged
Conversation
thisisdano
approved these changes
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4072. The task
make-tmp-directoryinrelease.jswas being started beforebuildtask was finished. This resulted in incomplete ZIP files of release builds.svg-sprite.jsso the streams are returned after they finishsvg-spriteas parallel taskAdditional information
Steps to test:
npx gulp releasescss/utilities/palettesas well asimg/andimg/usa-iconsPreviously, builds looked successful but img directory would be empty or more nested SCSS folders would be empty. Aside from JS directory being missing.
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.