Refactor all variables as defaults#1536
Merged
Merged
Conversation
Contributor
Author
|
This is definitely a breaking change. It seems safe to deprecate |
juliasolorzano
approved these changes
Oct 27, 2016
juliasolorzano
left a comment
There was a problem hiding this comment.
🚀 going to go ahead and merge into the rename-scss branch to keep moving things forward.
| $font-bold: 700; | ||
| // These variables drive almost every aspect of the U.S. Web Design | ||
| // system. Every variable is declared as !default so that it can be | ||
| // overridden by a previous import. |
There was a problem hiding this comment.
I've got an example of this in the new README.md changes here. Once this gets merged in, I'll update here to point to that example. ^5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stagingand rebase.This is a proposed fix for #1535 and #1532. It deprecates
core/defaultsandcore/grid-settingsin favor ofcore/variableswith!defaultvariable declarations that allow any variable to be overridden if it's set before being imported.I'm documenting some of my findings from searching through github for usage examples in #1535, but in the meantime I would love a gut check.