Skip to content

[UI component] Using sr-only mixing for .usa-sr-only class#1387

Merged
msecret merged 1 commit into
uswds:stagingfrom
carlosvalle:usa-sr-only
Aug 11, 2016
Merged

[UI component] Using sr-only mixing for .usa-sr-only class#1387
msecret merged 1 commit into
uswds:stagingfrom
carlosvalle:usa-sr-only

Conversation

@carlosvalle

Copy link
Copy Markdown
Contributor

Description

Refactoring .usa-sr-only class to use sr-only() mixin

Additional information

Before

// Screen reader only helper
.usa-sr-only {
position: absolute;
left: -999em;
}

@mixin sr-only() {
  position: absolute;
  left: -999em;
}

After

// Screen reader only helper
@mixin sr-only() {
  position: absolute;
  left: -999em;
}

.usa-sr-only {
  @include sr-only();
}

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@msecret msecret merged commit c807e5b into uswds:staging Aug 11, 2016
@carlosvalle carlosvalle deleted the usa-sr-only branch August 11, 2016 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants