Skip to content

[Website] Removing descendent reference from unstyled list utility.#1372

Closed
juliasolorzano wants to merge 1 commit into
releasefrom
je-fix_sidenav
Closed

[Website] Removing descendent reference from unstyled list utility.#1372
juliasolorzano wants to merge 1 commit into
releasefrom
je-fix_sidenav

Conversation

@juliasolorzano

Copy link
Copy Markdown

Description

This pull request cancels out the list styles from the websites sidenav that were introduced here. I am assuming that this does not work as expected b/c it is a mixin, but would need to do some more digging to verify.

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@msecret

msecret commented Aug 3, 2016

Copy link
Copy Markdown
Contributor

Is the addition of the descendent reference break something else somewhere on the site? Or are the accordions broken in some way?

@juliasolorzano

Copy link
Copy Markdown
Author

@msecret good question! As far as I can tell, this reference in the utility only breaks the sub navigation on the website. When debugging, I found that it is where the bug was introduced into the websites code base.

However, being specific here does make sense and am closing this in favor of #1374.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects: Documentation Relates to documentation. Should this be in uswds-site?

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants