[Website] Update incorrect documentation on variables#1333
Conversation
The documentation on this is now incorrect as variables.scss is no longer being imported so is not technically where these things are defined. Also, the way this was previously worded, it sounded like it was suggesting people to modify the src files of the standards which I've been working hard to stop from happening because it's a terrible practice.
|
This looks good, the only issue I have is the "importing it before uswds in Sass" bit. I think it could be rewritten a bit. Maybe say:
or
Possibly addresses #1334 although I wonder if we need to add a section in https://standards.usa.gov/getting-started/developers/ |
|
@maya This looks good to me. Also, I'm happy to chat more about adding a new section to the Getting Started section, if you think that this is necessary. |
|
@kategarklavs cool, and just checking "changing variable values and importing it before uswds in Sass." sounds OK to you? |
|
@maya Hello again, and apologies for not being clear before — that sounds good to me 👍 |
Description
The documentation on this is now incorrect as variables.scss is no longer being imported so is not technically where these things are defined.
Additional information
Also, the way this was previously worded, it sounded like it was suggesting people to modify the src files of the standards which I've been working hard to stop from happening because it's a terrible practice.
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.