[WIP] [Components]: Remove variables.scss from import#1330
Merged
Conversation
Contributor
|
I'm going to merge this without the documentation changes because I think it's more important for it to be done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes
core/_variables.scssfrom the import in thestylesheets/allfile. There's alreadydefaults.scsswhich have the variables. This will allow people to override our variables with their own by declaring their variables before theallimport.Resolves: #1168, #952.
Questions:
Do the names of the files still make sense. variables.scss and defaults.scss or should we consider renaming them to, for example:
variables(default variables) +variables-custom(for your own)variables-defaultsandvariables-custom/variablesIdeally, we can include some documentation on the site for how to do this.
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed. [only styleguide lint errors unrelated to this but which i fixed in [Website]: Fix lint errors in styleguide.scss #1331]cc: @msecret