Skip to content

[Website]: Remove deadlink from form controls and form templates accessibility section#1316

Merged
ericadeahl merged 3 commits into
stagingfrom
remove-deadlink
Jul 13, 2016
Merged

[Website]: Remove deadlink from form controls and form templates accessibility section#1316
ericadeahl merged 3 commits into
stagingfrom
remove-deadlink

Conversation

@maya

@maya maya commented Jul 12, 2016

Copy link
Copy Markdown
Contributor

Description

Removes deadlink from form controls and form templates section and updates the sentence text.

Also fixes an incorrect link on form controls that was linking to itself when it should be linking to form templates.

Additional information

This is what it looks like:

screen shot 2016-07-12 at 10 57 00 am

Resolves: #1313.

@ericadeahl

Copy link
Copy Markdown

@maya That second sentence is also confusing. ("In addition, when creating forms with multiple controls or customizing these templates, be sure to:") I think we could just remove it. Thoughts @kategarklavs ?

@kategarklavs

Copy link
Copy Markdown
Contributor

@ericadeahl Agree that this could be clearer. How do you all feel about the following?

"When you're creating forms with multiple controls or customizing these templates, make sure the order of the form controls is the same in the HTML as it is on the screen. Please don't use CSS to rearrange the form controls. Screen readers narrate forms in the order they appear in the HTML, and rearranging that order can provide a compromised experience for some users."

If you all think the additional note at the end isn't necessary, feel free to cut(!)

@maya

maya commented Jul 12, 2016

Copy link
Copy Markdown
Contributor Author

@kategarklavs we're referring to the whole section here which includes many bullet points: https://standards.usa.gov/form-templates/ so I don't think we should change that.

@ericadeahl

Copy link
Copy Markdown

@kategarklavs You can see the text in context here: https://standards.usa.gov/form-templates/ We're just trying to make the introduction text before the bullets clearer. It currently reads:

"As you customize these templates, make sure they meet the accessibility guidelines in this introduction and as described for each control.

In addition, when creating forms with multiple controls or customizing these templates, be sure to:"

The two sentences are referring to the same list of instructions, so "in addition" doesn't make sense, and "when customizing these templates" is redundant. I thought maybe we could just cut out the second sentence.

@kategarklavs

Copy link
Copy Markdown
Contributor

@ericadeahl Word -- thanks for clarifying (and +1 to removing the in addition). Would you all like me to take a more comprehensive look at the whole section, too, or is the removal of the in addition good for now?

@ericadeahl

Copy link
Copy Markdown

@kategarklavs Cool, I think we're good for now. @maya let's just remove that sentence starting with "in addition"

@kategarklavs

Copy link
Copy Markdown
Contributor

Sounds good!

@maya

maya commented Jul 12, 2016

Copy link
Copy Markdown
Contributor Author

@ericadeahl @kategarklavs done in 3a955dc.

@ericadeahl ericadeahl merged commit 741a9d0 into staging Jul 13, 2016
@ericadeahl ericadeahl deleted the remove-deadlink branch July 13, 2016 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants