[Forms] Fix label and fieldset for iOS/OS X Voiceover#1220
Closed
maya wants to merge 5 commits into
Closed
Conversation
Contributor
Author
|
@nickbristow can we add some background info about this to our accessibility guidance content? |
Contributor
|
@maya 👍 |
Contributor
Author
|
@nickbristow will be drafting up some documentation. |
2 tasks
Contributor
Author
|
Closing in favor of #1221. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fieldset and legend are not supported by VoiceOver on iOS and OS X, so this changes our code so it will work. This is not the ideal way but necessary to make Apple work, bugs have been reported about this issue Apple already.
This also fixes some of our labels that were still reading different pies instead of historical figures.
cc: @nickbristow
Fixes: #792.