[Website]: Fix line breaks on typography page#1214
Merged
Conversation
|
@maya is there a reason why a new class name was added instead of incorporating this change into this line? https://github.com/18F/web-design-standards/blob/017fe1d45461b90b7b1322e532e4fde8628eeadf/docs/doc_assets/css/styleguide.scss#L817 |
Contributor
Author
|
@juliaelman it's a separate rule for just those longer text examples. That line groups heading elements (h1-h6) which it does not apply to. |
| </div> | ||
| <div class="usa-font-example usa-width-one-half"> | ||
| <p><em>Italic body copy. A series of <br>sentences together which <br>make a paragraph.</em></p> | ||
| <p class="font-example-paragraph"><em>Italic body copy. A series of <br>sentences together which <br>make a paragraph.</em></p> |
There was a problem hiding this comment.
Is there a reason why the line breaks were left in here?
Contributor
Author
There was a problem hiding this comment.
Removed that and the remaining <br>s in 2d81e6c.
|
LGTM - thanks Maya! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes line breaks on typography page for body text and italic text.
Additional information
This is what it looks like on mobile:
This is what it looks like on desktop:
Fixes: #615.