Skip to content

[Tables] Fix table background overlap#1209

Merged
msecret merged 1 commit into
stagingfrom
fix-table-background
May 31, 2016
Merged

[Tables] Fix table background overlap#1209
msecret merged 1 commit into
stagingfrom
fix-table-background

Conversation

@maya

@maya maya commented May 31, 2016

Copy link
Copy Markdown
Contributor

Description

Prevents page background from interfering with table background.

Additional information

This is what it looks like:

screen shot 2016-05-31 at 12 25 17 pm

Fixes: #353.


thead {
tr {
th {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this fix the issue (the th should already be nested in a a tr) and why was the rule tr before?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the white background will override the gray table header unless this is changed to th.

@msecret msecret merged commit 89be34e into staging May 31, 2016
@maya maya deleted the fix-table-background branch June 16, 2016 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants