Screener/CircleCI integration#1207
Conversation
ac1ccf3 to
49c5762
Compare
| background: true | ||
| - sleep 20 | ||
| # run tests | ||
| - ./screener-ci.sh $SCREENER_API_KEY $SCREENER_GROUP_ID $CIRCLE_BUILD_NUM |
There was a problem hiding this comment.
Does this fail the build if screener detects visual changes?
There was a problem hiding this comment.
yep, the build fails if any changes are detected. Someone will have to validate those changes and kick off the build again once those changes are accepted.
There was a problem hiding this comment.
Is the build kicked off by somebody going into Travis and restarting it?
I think this looks great btw. I'll start a discussion with team to see if we can merge now.
There was a problem hiding this comment.
Thanks! I think you'll always have to rebuild manually, unfortunately.
There was a problem hiding this comment.
Oh wait, that makes sense you would because it might not be a code change. K well we still have time to figure out what the full workflow would be.
Screener Integration
This PR affects the test builds of the repository. During a build, it connects the CI server to Screener's (https://screener.io) cloud server and checks for visual regressions in the page's layout. These tests are defined via Screener's interface and must be manually configured. Some basic checks have been put in place for purposes of testing these changes, they can be found in the
uswdsproject under the namestyleguide-ci.Description
Additional information
The changes made to the circle.yml file are pretty basic, there are probably optimizations that can be made. Currently, running these regression tests appears to add about 5 minutes to the build; this represents a significant increase in running time.