Skip to content

[UI Component]: Fix aria hidden (simple)#1196

Closed
maya wants to merge 2 commits into
stagingfrom
fix-accordion-aria
Closed

[UI Component]: Fix aria hidden (simple)#1196
maya wants to merge 2 commits into
stagingfrom
fix-accordion-aria

Conversation

@maya

@maya maya commented May 26, 2016

Copy link
Copy Markdown
Contributor

Description

Removes display: none from aria-hidden="true" and moves that to usa-accordion.

Fixes: #1120.

@maya maya changed the title [UI Component]: Fix accordion aria (simple) [UI Component]: Fix aria hidden (simple) May 26, 2016
@joshbruce

Copy link
Copy Markdown

@maya - Very nice alternative - didn't think of it myself until your comment. Well done!

@msecret - If I'm thinking about this solution, combined with the utility suggestion from #1192 we would get something like:

@mixin aria-hidden() {
  &[aria-hidden=true] {
    display: none;
  }
}

To allow developers to @include within any class or element; thereby, allowing any element to opt-in to being toggled based on aria-hidden state based on CSS, yeah?

@maya

maya commented May 26, 2016

Copy link
Copy Markdown
Contributor Author

@joshbruce @msecret where else are we using "allowing any element to opt-in to being toggled based on aria-hidden state" on the site?

@maya

maya commented May 31, 2016

Copy link
Copy Markdown
Contributor Author

Will use #1192 instead of this.

@maya maya closed this May 31, 2016
@maya maya deleted the fix-accordion-aria branch July 15, 2016 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants