Fixes issue #1120 by removing display: none from aria-hidden, doesn't…#1153
Closed
ducklet wants to merge 1 commit into
Closed
Fixes issue #1120 by removing display: none from aria-hidden, doesn't…#1153ducklet wants to merge 1 commit into
ducklet wants to merge 1 commit into
Conversation
… impact anything but accordion component which should be addressed separately
Contributor
|
Hey @ducklet! Thanks so much for submitting this. In order for us to not break the accordion component, we'll need to fix that before adding this in. |
Closed
|
@ducklet - Per the request on #1137 - I'm curious, as I don't know if it's possible.
I would prefer the former as it would be easiest. I've done some very brief Google-fu and saw that it was a feature request, but not finding instructions on doing it. Maybe @maya knows? |
Contributor
|
@joshbruce opening a new PR would be best! I'm going to close this out since it doesn't have what we need in order to accept it, i.e. we can't fix one thing and break another. But we agree with the intent of this 💯 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… impact anything but accordion component which should be addressed separately (see #1121, #1122, et al).
Regardless of how the accordion issue is solved, it is not appropriate for aria-hidden=true to have additional rules; instead, a class with display: none should be used where needed.
Thanks!