Fix radio and checkbox vertical alignment#1127
Merged
Merged
Conversation
Contributor
Author
|
This PR has design changes @ericadeahl and @carodew. Let me know if it's OK! |
Contributor
|
LGTM! |
| display: inline-block; | ||
| height: 1.8rem; | ||
| line-height: 0.8; | ||
| line-height: 1.8rem; |
Contributor
There was a problem hiding this comment.
What if somebody changes their base font sizes, then wouldn't this no longer be aligned? Could this be written so it accounts for that?
Contributor
Author
There was a problem hiding this comment.
Yes, it accounts for that. This only looks at the size of the button not text, it will always be centered.
Here I made the text way bigger and it's still centered:
c0a9a95 to
ee33a55
Compare
Contributor
|
I checked out the code and rebased this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the vertical alignment of checkboxes ☑️ and radio buttons 🔘 (without resorting to use magic numbers). The issue was brought up in #1105, however this supersedes #1105.
This is what it looks like NOW...
Checkboxes:
Radio buttons:
This is what it looks like BEFORE...
Checkboxes:
Radio buttons:
*You can see that all of the radio buttons are to low and the first and third checkboxes (Sojourner and Booker) are too low.