Skip to content

Fix table alignment#1117

Merged
msecret merged 3 commits into
18f-pages-stagingfrom
fix-table-alignment
May 10, 2016
Merged

Fix table alignment#1117
msecret merged 3 commits into
18f-pages-stagingfrom
fix-table-alignment

Conversation

@maya

@maya maya commented Apr 11, 2016

Copy link
Copy Markdown
Contributor

This makes sure the first item in the table aligns left like all the other fields. Currently the first item in the table is centered.

Before:

screen shot 2016-04-11 at 3 35 04 pm

After:

screen shot 2016-04-11 at 3 36 16 pm

TODO:

  • update other files (dist and docs) that need this update

@maya maya changed the title [WIP] Fix table alignment Fix table alignment Apr 18, 2016
@maya

maya commented Apr 18, 2016

Copy link
Copy Markdown
Contributor Author

@ericadeahl @carodew this has design changes, but i'm guessing it was a visual bug before. Can you let me know if this gets a 👍 ?

@ericadeahl

Copy link
Copy Markdown

@maya Looks good to me! (And it's helpful to have the screenshot, thanks!)

Comment thread circle.yml
@@ -0,0 +1,26 @@
machine:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these changes in here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the circle CI updates that came after this branch was created.

@msecret

msecret commented Apr 19, 2016

Copy link
Copy Markdown
Contributor

@maya it seems like this has to be rebased.

@msecret msecret closed this Apr 19, 2016
@msecret msecret reopened this Apr 19, 2016
@msecret

msecret commented Apr 19, 2016

Copy link
Copy Markdown
Contributor

ahh sorry, I closed it by mistake

@maya

maya commented Apr 19, 2016

Copy link
Copy Markdown
Contributor Author

@msecret I did rebase it, and also did a pull from 18f-pages-staging. It didn't have the necessary stuff from Circle CI so the test was failing which is why I did that.

@msecret msecret force-pushed the fix-table-alignment branch from 0dd0ec6 to a04b368 Compare April 19, 2016 18:29
@msecret msecret force-pushed the fix-table-alignment branch from a04b368 to 6d3f804 Compare April 29, 2016 18:13
@msecret msecret force-pushed the fix-table-alignment branch from 6d3f804 to 70155c2 Compare May 10, 2016 20:00
@msecret

msecret commented May 10, 2016

Copy link
Copy Markdown
Contributor

I rebased it

@msecret msecret merged commit c1077c1 into 18f-pages-staging May 10, 2016
@maya maya deleted the fix-table-alignment branch May 11, 2016 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants