make accordion class selector more inclusive#1085
Merged
Merged
Conversation
| }); | ||
|
|
||
| $('[class^=usa-accordion]').each(function() { | ||
| $('*[class*=usa-accordion]').each(function() { |
Contributor
There was a problem hiding this comment.
What's the reason for not doing $('.usa-accordion')?
Contributor
Author
There was a problem hiding this comment.
the reason i didn't do that is because there is another class to check for as well, namely usa-accordion-bordered
Contributor
There was a problem hiding this comment.
Ah I remember now.
I'm of the opinion that $('.usa-accordion,.usa-accordion-bordered') is a better solution. This is because with our CSS methodology, we could have classes like .usa-accordion-child that wouldn't represent the whole accordion, but an element of the accordion.
I don't see us creating that many different accordion types, and I think I'd be expected that if you did, you'd expect to have to add a selector for a new accordion type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug (#1083) where the accordion was not being initialized in the JS when there was a css class preceding the
usa-accordionclass (i.e.,div class="foo usa-accordion")