CC: @maya, @msecret, @juliaelman

💯 let's also plan on updating the docs and include a link to these new templates too! https://github.com/18F/web-design-standards/blob/18f-pages-staging/CONTRIBUTING.md#submitting-an-issue

Looking through my trove of notes on this subject, I found this mega PULL_REQUEST_TEMPLATE that I've used parts of. I don't think we need to actually use all of it. We could pick and choose some sections from this. I like the idea of including a checklist that will help contributors get their PR reviewed and merged quickly.

Short description explaining the high-level reason for the pull request

Additions

Removals

Changes

Testing

Review

• @user

Screenshots

Todos

Checklist

• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows the standards laid out in the front end playbook
• Passes all existing automated tests
• New functions include new tests
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged
• Visually tested in supported browsers and devices
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

Nice! I can see this being very useful, but we should definitely do some user research/testing of our contributors.

Superseded by #1151.