Correction patch to SP800-53 catalog#229
Merged
david-waltermire merged 1 commit intousnistgov:masterfrom Sep 25, 2018
Merged
Conversation
…' to controls containing withdrawn control enhancements
This was referenced Sep 6, 2018
This was referenced Sep 13, 2018
david-waltermire
approved these changes
Sep 25, 2018
Contributor
david-waltermire
left a comment
There was a problem hiding this comment.
Looks good. Thanks for these corrections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new OSCAL draft catalog corrects a problematic (semantically consequential) bug in the OSCAL SP800-53 catalog, where a "withdrawn" status (property) was being misattributed to controls that are not withdrawn, but only have enhancements associated that are (happen to be) withdrawn.
Otherwise it makes no changes outside of a new timestamp (in the header comment) and document ID (uuid).
Committer Notes
This PR should finally align with the upstream master. It replaces withdrawn PR #228, which replaced PR #227. (Slowly, I am figuring out the git bits.)
All Submissions:
Changes to Core Features:
Removed
<prop class="status">Withdrawn</prop>from controls not designated as "Withdrawn" in the NVD source data. Without this correction the OSCAL is wrong.The production pipeline that produces the catalog (not maintained in this branch) has also been updated so the correction will stick.