hotfix invalid syntax#2078
Merged
iMichaela merged 1 commit intousnistgov:developfrom Nov 21, 2024
wandmagic:hotfix/develop
Merged
hotfix invalid syntax#2078iMichaela merged 1 commit intousnistgov:developfrom wandmagic:hotfix/develop
iMichaela merged 1 commit intousnistgov:developfrom
wandmagic:hotfix/develop
Conversation
iMichaela
approved these changes
Nov 21, 2024
Contributor
iMichaela
left a comment
There was a problem hiding this comment.
This corrections are reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
Two instances of a orphaned parenthesis which somehow got into develop.
I would recommend improved integration/unit tests to validate to prevent this in the future.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features: