Update node version for build: v16 -> v20#2034
Merged
iMichaela merged 2 commits intousnistgov:developfrom Aug 15, 2024
Merged
Conversation
Will test in the pipeline
markdown-link-check seems to have intermittent errors when checking multiple files at a time. This change might be a workaround.
iMichaela
approved these changes
Aug 15, 2024
Contributor
iMichaela
left a comment
There was a problem hiding this comment.
All changes are good. Tested locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm hoping that this will resolve the error in #2018, which fails with:
ReferenceError: ReadableStream is not definedandWill test in the pipeline
The pipeline failed, so before we can see if the unsupported engine issue above is resolved, the new pipeline error needs to be fixed.
After investigating a little further, it seems like there might be an issue when checking multiple files for broken links at once, so the 2nd commit checks 1 file at a time as a workaround.
Committer Notes
{Please provide a brief description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please include [WIP] at the beginning of the title or mark the PR as DRAFT.}
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features: