You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: build/README.md
+2-1Lines changed: 2 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -34,7 +34,8 @@ Developers can generate schemas locally using the `make artifacts` command.
34
34
Developers can also generate individual artifacts using the following commands:
35
35
36
36
*`make schemas`: Generates the JSON Schemas and XSDs off of the source Metaschemas;
37
-
*`make converters`: Generates the XSLT stylesheets for JSON<->XML conversion off of the source Metaschemas.
37
+
*`make converters`: Generates the XSLT stylesheets for JSON<->XML conversion off of the source Metaschemas;
38
+
*`make resolved-metaschemas`: Resolves external entities (XXE) present in the source OSCAL Metaschema modules for use with tools that do not support XXEs.
# Production of transformed source Metaschema modules without external entities (XXEs)
2
+
3
+
Date: 08/25/2023
4
+
5
+
## Status
6
+
7
+
Approved
8
+
9
+
## Context
10
+
11
+
We wish to remove or mitigate points friction encountered by NIST or community OSCAL developers producing tooling that consumes the OSCAL Metaschema module sources.
12
+
13
+
The OSCAL Metaschema modules currently use external entities to prevent duplication of constraint data.
14
+
These external entities are important for modeling ergonomics and cannot be removed until a Metaschema-native approach is stabilized, however external entities have a storied history of abuse.
15
+
So called "XML External Entity (XXE) Attacks", along with the additional complexity needed to support external entity resolution, have led to a situation where many XML parsers do not ship with XXE functionality.
16
+
This has put additional burden on OSCAL tool developers seeking to consume the source Metaschemas, who have either had to choose from the small subset of XML parsers that support external entities (if one exists for their target language at all) and inherit all additional risks that come with XXEs, or perform transformation of the source Metaschema modules before consuming them.
17
+
18
+
- Related to Issue [#1665](https://github.com/usnistgov/OSCAL/issues/1665)
19
+
20
+
## Decision
21
+
22
+
The NIST OSCAL Team should include the "resolved" Metaschema module sources as an artifact generated upon release.
23
+
Additionally, the NIST OSCAL Team should document the process for obtaining a resolved Metaschema module as part of the [streamlined build process](./0005-repository-reorganization.md#streamlined-build-process).
24
+
25
+
In the event that Metaschema stabilizes constraint imports, the NIST OSCAL Team will review this ADR and potentially determine a deprecation strategy for these generated artifacts in the relevant releases.
26
+
27
+
## Consequences
28
+
29
+
This decision will not have any breaking changes to our process, however:
30
+
31
+
1. The NIST team will be responsible for reviewing the additional artifacts before performing a release.
32
+
2. In the event that Metaschema stabilizes constraint imports, the NIST OSCAL team will have to maintain deprecated artifacts until the next major version.
Copy file name to clipboardExpand all lines: src/release/release-readme.txt
+3-3Lines changed: 3 additions & 3 deletions
Original file line number
Diff line number
Diff line change
@@ -9,8 +9,8 @@ Documentation for the OSCAL models can be found at: https://pages.nist.gov/OSCAL
9
9
10
10
This release provides 2 types of resources, each located in a different subdirectory:
11
11
12
-
- xml: Provides the XML schemas and content converters that are needed to support the OSCAL model XML-based formats. Instructions for using this information can be found at: https://github.com/usnistgov/OSCAL/tree/master/xml.
13
-
- json: Provides the JSON schemas and content converters that are needed to support the OSCAL model JSON-based formats. Instructions for using this information can be found at: https://github.com/usnistgov/OSCAL/tree/master/json.
12
+
- `xml/` and `json/`: Provides the XML and JSON schemas and content converters that are needed to support the OSCAL model. Instructions for using these artifacts can be found at https://github.com/usnistgov/OSCAL/blob/develop/build/README.md#artifact-usage
13
+
- `metaschema/`: Provides the source OSCAL Metaschema modules with all external entities (XXE) resolved for tools that do not support XXEs.
14
14
15
15
These directories provide stable, released versions of the resources provided on the OSCAL GitHub repository: https://github.com/usnistgov/OSCAL.
16
16
@@ -32,6 +32,6 @@ OSCAL is being developed in a public GitHub repository, in collaboration with in
32
32
- Help with developing OSCAL models and associated content.
33
33
- Assistance with developing documentation, tutorials, and other informational resources.
34
34
35
-
If you are interested in helping, please visit or contributing page for more information at: https://github.com/usnistgov/OSCAL/blob/master/CONTRIBUTING.md.
35
+
If you are interested in helping, please visit or contributing page for more information at: https://github.com/usnistgov/OSCAL/blob/main/CONTRIBUTING.md.
36
36
37
37
Please direct any questions, comments, concerns, or kudos by email to: oscal@nist.gov.
0 commit comments