Use synthetic paths in test_dir.py to avoid Windows CI failures#1909
Merged
Conversation
…issues Replace tmp_path-based paths with string paths in TestGetProjectNameFromDir since get_project_name_from_dir() only reads .name and never touches the filesystem. This avoids Windows-specific failures where directory names like "..." are interpreted as parent traversal. Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/c5cf2c22-5f12-46c3-a10e-ee4f3dd165a7 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix filesystem directory creation with OS-special names in tests
Use synthetic paths in test_dir.py to avoid Windows CI failures
Apr 9, 2026
nathanjmcdougall
approved these changes
Apr 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_project_name_from_dir()only readsPath.name— it never touches the filesystem. Tests were unnecessarily creating real directories viatmp_path, which fails on Windows where"..."is interpreted as../..traversal and trailing dots are silently stripped.tests/usethis/_file/test_dir.py: Replace alltmp_path-based paths with string paths ("/fake/...") since no filesystem access is neededusethis-python-testskill (v1.5 → v1.6): Add guidance on preferring synthetic paths when testing pure path-metadata logic