Add test placement guidance to usethis-python-test skill#1898
Merged
Conversation
… v1.4) Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/c190dab3-7bae-474b-8b73-f1f67ec0ea5b Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test file structure for KeyValueFileManager methods
Add test placement guidance to usethis-python-test skill
Apr 8, 2026
nathanjmcdougall
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for class methods were being placed in the test file for utilities they use internally, rather than in the test file for the class where the methods are defined — breaking the structural correspondence between source and test files.
Changes
usethis-python-testskill (v1.3 → v1.4): Adds a new "Test file placement mirrors source file structure" subsection under "Test class organization", establishing that tests for a method onSomeClassinsome_module.pybelong underTestSomeClassintest_some_module.py, regardless of which internal utilities the method delegates to.