Skip to content

Replace private tomlkit _insert_at with public API in _ensure_project_name#1859

Merged
nathanjmcdougall merged 4 commits into
mainfrom
copilot/reconsider-private-usage-insert-at
Apr 7, 2026
Merged

Replace private tomlkit _insert_at with public API in _ensure_project_name#1859
nathanjmcdougall merged 4 commits into
mainfrom
copilot/reconsider-private-usage-insert-at

Conversation

Copilot AI commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Replace private tomlkit _insert_at with public API in valid.py
  • Add test_comment_in_project_section test for 100% coverage
  • Restore "Generally Important Instructions" and "Lessons" sections inline in AGENTS.md (477 lines, within limit); remove docs/agents-instructions.md

Copilot AI linked an issue Apr 7, 2026 that may be closed by this pull request
Reconsider private usage of _insert_at from tomlkit #1459
Closed
Copilot AI changed the title [WIP] Refactor usage of _insert_at in tomlkit to public interface Replace private tomlkit _insert_at with public API in _ensure_project_name Apr 7, 2026
Copilot AI requested a review from nathanjmcdougall April 7, 2026 10:48
@nathanjmcdougall nathanjmcdougall marked this pull request as ready for review April 7, 2026 10:55
nathanjmcdougall
nathanjmcdougall requested changes Apr 7, 2026
View reviewed changes
Comment thread AGENTS.md Outdated
@codecov

codecov Bot commented Apr 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq

codspeed-hq Bot commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 2 untouched benchmarks

Comparing copilot/reconsider-private-usage-insert-at (2d90223) with main (b868419)

Open in CodSpeed

Copilot AI requested a review from nathanjmcdougall April 7, 2026 11:03
@nathanjmcdougall nathanjmcdougall merged commit 4d68849 into main Apr 7, 2026
20 checks passed
@nathanjmcdougall nathanjmcdougall deleted the copilot/reconsider-private-usage-insert-at branch April 7, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nathanjmcdougall nathanjmcdougall nathanjmcdougall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nathanjmcdougall nathanjmcdougall

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reconsider private usage of _insert_at from tomlkit

2 participants

@nathanjmcdougall