Skip to content

Support SONAR_PROJECT_KEY as environment variable in CI#1852

Merged
nathanjmcdougall merged 4 commits into
mainfrom
copilot/support-sonar-project-key-env-var
Apr 7, 2026
Merged

Support SONAR_PROJECT_KEY as environment variable in CI#1852
nathanjmcdougall merged 4 commits into
mainfrom
copilot/support-sonar-project-key-env-var

Conversation

Copilot AI commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Add SONAR_PROJECT_KEY env var support in get_sonar_project_properties() (priority: CLI arg > env var > pyproject.toml)
  • Update help text in show.py to mention the env var
  • Add tests for env var behavior
  • Update docs/cli/reference.md to document the env var
  • Run static checks (all pass: prek + basedpyright)

Copilot AI linked an issue Apr 7, 2026 that may be closed by this pull request
Support SONAR_PROJECT_KEY as an environment variable in CI for usethis show sonarqube #929
Closed
@nathanjmcdougall
Changes before error encountered
cf26bca 
Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/51606972-a8e7-42ce-a5f7-c1bbf0c686f1

Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot AI requested a review from nathanjmcdougall April 7, 2026 10:04
@nathanjmcdougall

nathanjmcdougall commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator

@copilot pass static checks

@codspeed-hq

codspeed-hq Bot commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 2 untouched benchmarks

Comparing copilot/support-sonar-project-key-env-var (05a868c) with main (b868419)

Open in CodSpeed

@codecov

codecov Bot commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copilot AI commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

@copilot pass static checks

Fixed in 05a868c — added the missing pytest.MonkeyPatch type annotation for the monkeypatch parameter in test_show.py. All prek hooks and basedpyright now pass cleanly.

@nathanjmcdougall nathanjmcdougall changed the title [WIP] Support SONAR_PROJECT_KEY as environment variable in CI Support SONAR_PROJECT_KEY as environment variable in CI Apr 7, 2026
@nathanjmcdougall nathanjmcdougall marked this pull request as ready for review April 7, 2026 18:14
@nathanjmcdougall nathanjmcdougall merged commit 07df2a8 into main Apr 7, 2026
20 checks passed
@nathanjmcdougall nathanjmcdougall deleted the copilot/support-sonar-project-key-env-var branch April 7, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nathanjmcdougall nathanjmcdougall nathanjmcdougall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nathanjmcdougall nathanjmcdougall

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support SONAR_PROJECT_KEY as an environment variable in CI for usethis show sonarqube

2 participants

@nathanjmcdougall