Improve test discovery skill for error semantics changes#1835
Merged
Conversation
Add a new "Detect changes to error semantics" general principle that guides agents to trace transitive callers and run their tests when a refactoring changes which errors a function raises (e.g., collapsing distinct missing-key vs invalid-type error paths into a single default-returning behaviour). Bump skill version from 1.1 to 1.2. Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/eaac8d05-162b-4e1c-998c-dd7768575e6f Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test discovery for refactored callsites with different error semantics
Improve test discovery skill for error semantics changes
Apr 7, 2026
nathanjmcdougall
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent missed 21 downstream test failures when refactoring collapsed distinct error paths (missing-key → default vs invalid-type → raise) into a single default-returning wrapper. The
usethis-python-test-affected-findskill lacked guidance for this class of refactoring.