Only use files_manager in the test suite#1827
Merged
Merged
Conversation
…ents Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/88080084-95d1-46d8-88f6-43eef23f26b7 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor test suite to only use files_manager
Only use Apr 6, 2026
files_manager in the test suite
nathanjmcdougall
approved these changes
Apr 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests inconsistently used individual file manager context managers (
PyprojectTOMLManager,SetupCFGManager, etc.) instead of the unifiedfiles_manager(). This made tests fragile and inconsistent—files_manager()locks all managers atomically, which is the correct pattern.Test file changes (~270 replacements across 28 files)
with change_cwd(tmp_path), PyprojectTOMLManager():→with change_cwd(tmp_path), files_manager():PyprojectTOMLManager(), UVTOMLManager()into singlefiles_manager()asbinding cases: moved manager instantiation into the body sincefiles_manager()already locks the class-level state:files_manager, removed now-unused manager importsEnforcement hook
Added a
pygrep-language prek hookno-bare-managers-in-testsmatching^\s*with\b.*Manager\(intests/, excluding the three base manager infrastructure test files (test_ini_io_.py,test_toml_io_.py,test_yaml_io_.py) that legitimately use customMy*Manager()subclasses.