Add msg = ["'] to coverage.py exclude_also patterns#1593
Merged
Conversation
When EM ruff rules require error messages to be defined outside `raise` statements, the convention is `msg = "..."`. These lines should be excluded from coverage, just like `raise NotImplementedError`. Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/918aa6cc-e210-457c-86f9-0e589eea5030 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Ignore
Add Mar 27, 2026
msg = "*" lines in coveragemsg = ".*" to coverage.py exclude_also patterns
nathanjmcdougall
requested changes
Mar 27, 2026
…thout requiring closing quote Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/71169fc6-2da1-43ac-8f35-588dbb29b078 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
Add
Add Mar 27, 2026
msg = ".*" to coverage.py exclude_also patternsmsg = ["'] to coverage.py exclude_also patterns
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nathanjmcdougall
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When EM ruff rules are enabled,
raisemessages must be extracted to a preceding line — conventionallymsg = "..."ormsg = '...'(ruff's autofix uses this variable name). These lines should be excluded from coverage likeraise NotImplementedErroralready is. Per discussion, always exclude regardless of whether EM rules are active.msg = ["']toexclude_alsoinCoveragePyToolSpec.config_spec(), matching both single and double quote styles without requiring a closing quote (to support multi-line strings)pyproject.tomlcoverage config to match.coveragercandtox.inioutput formats✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.