Skip to content

Make --typecheck default to false for usethis init#1538

Merged
nathanjmcdougall merged 4 commits into
mainfrom
copilot/make-typecheck-default-false
Mar 25, 2026
Merged

Make --typecheck default to false for usethis init#1538
nathanjmcdougall merged 4 commits into
mainfrom
copilot/make-typecheck-default-false

Conversation

Copilot AI commented Mar 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Change init_typecheck_opt default from True to False in src/usethis/_ui/options.py
  • Update tests in tests/usethis/_ui/interface/test_init.py to reflect new default
  • Update docs/cli/reference.md to document --typecheck as opt-in
  • Run targeted tests to validate changes
  • Run code review and security checks
Original prompt

This section details on the original issue you should resolve

<issue_title>Make --typecheck default to false for usethis init</issue_title>
<issue_description>Many users will find a type checker too aggressive.</issue_description>

Comments on the Issue (you are @copilot in this section)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@nathanjmcdougall
Make --typecheck default to false for usethis init
35a2145 
Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/8d22ff93-1402-4a87-827e-ef25c89fa78a
Copilot AI changed the title [WIP] Update usethis init to set typecheck default to false Make --typecheck default to false for usethis init Mar 25, 2026
Copilot AI requested a review from nathanjmcdougall March 25, 2026 19:31
@nathanjmcdougall
Fix indentation in test_hook_included closing paren
286633a 
Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/8d22ff93-1402-4a87-827e-ef25c89fa78a
@nathanjmcdougall

nathanjmcdougall commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

@copilot you need to update the docs too

@nathanjmcdougall nathanjmcdougall mentioned this pull request Mar 25, 2026
Closed
@nathanjmcdougall
Update docs to reflect --typecheck defaulting to false
bb3f090 
Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/d3fd89e4-016d-4137-b9cd-b260d4f41c4b

Copilot AI commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

@copilot you need to update the docs too

Updated docs/cli/reference.md to list --typecheck as opt-in (matching --arch and --hook) and moved type checkers from the "all opt-out" bullet to a separate "opt-in" bullet in the feature summary. See bb3f090.

@nathanjmcdougall nathanjmcdougall marked this pull request as ready for review March 25, 2026 19:48
@codspeed-hq

codspeed-hq Bot commented Mar 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 2 untouched benchmarks

Comparing copilot/make-typecheck-default-false (bb3f090) with main (40cd6ef)

Open in CodSpeed

@codecov

codecov Bot commented Mar 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@nathanjmcdougall nathanjmcdougall merged commit f1eaa76 into main Mar 25, 2026
20 checks passed
@nathanjmcdougall nathanjmcdougall deleted the copilot/make-typecheck-default-false branch March 25, 2026 20:03
Copilot AI mentioned this pull request Mar 25, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nathanjmcdougall nathanjmcdougall nathanjmcdougall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nathanjmcdougall nathanjmcdougall

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make --typecheck default to false for usethis init

2 participants

@nathanjmcdougall