Fix failed pyproject.toml read when Unicode characters present#1422
Merged
Conversation
Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failed pyproject.toml read with unicode char present
Fix failed pyproject.toml read when Unicode characters present
Mar 19, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File I/O throughout the codebase omitted
encoding="utf-8", falling back to the system default. On platforms where the default is not UTF-8 (e.g. Windows), reading a file containing non-ASCII characters likeāwould raise aUnicodeDecodeError.Changes
_io.py(UsethisFileManager): Addencoding="utf-8"toread_text()andwrite_text()— this is the base class for all file managers includingPyprojectTOMLManager, so it covers the primary reported failure_file/yaml/io_.py: Addencoding="utf-8"toopen()for YAML file reads_init.py: Addencoding="utf-8"towrite_text()forpyproject.tomland__init__.pycreation_integrations/pytest/core.py: Addencoding="utf-8"towrite_text()forconftest.py_integrations/mkdocs/core.py: Addencoding="utf-8"towrite_text()fordocs/index.md_integrations/sonarqube/config.py: Addencoding="utf-8"toread_text()for.python-versiontest_read_file_with_unicode_charstotest_pyproject_toml_io_.pyasserting apyproject.tomlcontainingāin a comment is parsed successfullyOriginal prompt
This section details on the original issue you should resolve
<issue_title>Failed
pyproject.tomlread with unicode char present</issue_title><issue_description>The character
āin a comment meant thatusethisfailed to readpyproject.tomlwhen running the commandusethis tool import-linterDetails