Fix hooks printing errors to stderr instead of stdout (#1844)

Copilot · nathanjmcdougall · web-flow · commit acd3d4e19a9e · 2026-04-07T18:58:16.000+12:00
* Initial plan * Fix hooks to print errors to stdout instead of stderr and remove success messages The hooks were printing error output to stderr and a success message to stdout. In a pre-commit/prek context, stdout is the standard output stream for hook output. Using stderr for errors meant violations could go unseen while the success message on stdout always appeared. Changes: - check-docstring-substrings.py: errors to stdout, removed success msg - check-comment-keywords.py: errors to stdout, removed success msg - check-banned-words.py: errors to stdout, removed success msg - Removed unused sys imports from all three hooks Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/16f73dc6-f9ed-489f-aabd-b89069012a57 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
diff --git a/hooks/check-banned-words.py b/hooks/check-banned-words.py
@@ -10,7 +10,6 @@
 
 import argparse
 import re
-import sys
 from pathlib import Path
 
 
@@ -35,7 +34,7 @@ def main() -> int:
     own_name = Path(__file__).name
 
     if not hooks_dir.is_dir():
-        print(f"ERROR: {hooks_dir} is not a directory.", file=sys.stderr)
+        print(f"ERROR: {hooks_dir} is not a directory.")
         return 1
 
     violations: list[str] = []
@@ -52,15 +51,11 @@ def main() -> int:
                     violations.append(f"  {py_file}:{lineno}: {line.strip()}")
 
     if violations:
-        print(
-            "ERROR: Banned word(s) found in hook scripts:",
-            file=sys.stderr,
-        )
+        print("ERROR: Banned word(s) found in hook scripts:")
         for v in violations:
-            print(v, file=sys.stderr)
+            print(v)
         return 1
 
-    print("No banned words found in hook scripts.")
     return 0
 
 
diff --git a/hooks/check-comment-keywords.py b/hooks/check-comment-keywords.py
@@ -8,7 +8,6 @@
 from __future__ import annotations
 
 import argparse
-import sys
 import tokenize
 
 
@@ -37,12 +36,11 @@ def main() -> int:
         violations.extend(_check_file(filepath, keywords))
 
     if violations:
-        print("ERROR: Banned comment keyword(s) found:", file=sys.stderr)
+        print("ERROR: Banned comment keyword(s) found:")
         for v in violations:
-            print(v, file=sys.stderr)
+            print(v)
         return 1
 
-    print("No banned comment keywords found.")
     return 0
 
 
diff --git a/hooks/check-docstring-substrings.py b/hooks/check-docstring-substrings.py
@@ -10,7 +10,6 @@
 import argparse
 import ast
 import re
-import sys
 
 
 def main() -> int:
@@ -38,12 +37,11 @@ def main() -> int:
         violations.extend(_check_file(filepath, compiled))
 
     if violations:
-        print("ERROR: Forbidden pattern(s) found in docstrings:", file=sys.stderr)
+        print("ERROR: Forbidden pattern(s) found in docstrings:")
         for v in violations:
-            print(v, file=sys.stderr)
+            print(v)
         return 1
 
-    print("No forbidden patterns found in docstrings.")
     return 0
 
 
