Skip to content

Commit 572faf5

Browse files
Reword comment for clarity and conciseness
1 parent a275348 commit 572faf5

1 file changed

Lines changed: 5 additions & 9 deletions

File tree

src/usethis/_tool/impl/ruff.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -423,15 +423,11 @@ def apply_rule_config(self, rule_config: RuleConfig) -> None:
423423
is_selected = self.select_rules(rule_config.get_all_selected())
424424
is_ignored = self.ignore_rules(rule_config.get_all_ignored())
425425

426-
# It's a bit spammy to go into detail about per-file level config, but if we
427-
# haven't mentioned anything yet then we definitely need at least one message to
428-
# avoid a misleading silence which wouldn't draw attention to the modified file.
429-
# https://github.com/usethis-python/usethis-python/issues/881
430-
# Arguably this is questionably behaviour and we should just always display the
431-
# message but I think let's wait for user feedback. I am already concerned
432-
# that we are displaying too many messages about rather trivial changes. It's a
433-
# balancing act and I think basically we need a way to control verbosity at a more
434-
# granular level. See
426+
# We don't want to spam the user with verbose messages about per-file ignores.
427+
# On the other hand, if we haven't displayed any messages at all, we need to
428+
# avoid a misleading silence, which would imply we haven't modified a file.
429+
# This is probably a workaround until there is more sophisticated support for
430+
# verbosity control.
435431
# https://github.com/usethis-python/usethis-python/issues/884
436432
with usethis_config.set(alert_only=is_selected or is_ignored):
437433
self.ignore_rules_in_glob(

0 commit comments

Comments
 (0)