Properly use test deps in is_used heuristic

nathanjmcdougall · nathanjmcdougall · commit 567b83780d2c · 2025-02-21T22:54:44.000+13:00
diff --git a/src/usethis/_tool.py b/src/usethis/_tool.py
@@ -124,6 +124,9 @@ def is_used(self) -> bool:
         for dep in self.get_dev_deps(unconditional=True):
             if is_dep_in_any_group(dep):
                 return True
+        for dep in self.get_test_deps(unconditional=True):
+            if is_dep_in_any_group(dep):
+                return True
 
         return False
 
diff --git a/tests/usethis/test_usethis_tool.py b/tests/usethis/test_usethis_tool.py
@@ -40,18 +40,18 @@ def name(self) -> str:
         return "my_tool"
 
     def get_dev_deps(self, *, unconditional: bool = False) -> list[Dependency]:
-        return [
+        deps = [
             Dependency(name=self.name),
             Dependency(name="black"),
             Dependency(name="flake8"),
         ]
+        if unconditional:
+            deps.append(Dependency(name="pytest"))
+        return deps
 
     def print_how_to_use(self) -> None:
         box_print("How to use my_tool")
 
-    def get_extra_dev_deps(self) -> list[Dependency]:
-        return [Dependency(name="pytest")]
-
     def get_pre_commit_repos(self) -> list[LocalRepo | UriRepo]:
         return [
             UriRepo(
@@ -249,7 +249,25 @@ def test_empty(self, uv_init_dir: Path):
             # Assert
             assert not result
 
-        def test_extra_dev_deps(self, uv_init_dir: Path):
+        def test_dev_deps(self, uv_init_dir: Path):
+            # Arrange
+            tool = MyTool()
+
+            with change_cwd(uv_init_dir):
+                add_deps_to_group(
+                    [
+                        Dependency(name="black"),
+                    ],
+                    "dev",
+                )
+
+                # Act
+                result = tool.is_used()
+
+            # Assert
+            assert result
+
+        def test_test_deps(self, uv_init_dir: Path):
             # Arrange
             tool = MyTool()
 
