Address review feedback: list[object] and NotImplementedError

Copilot · nathanjmcdougall · Copilot · commit 4c6efec6c478 · 2026-03-13T03:49:59.000Z
Co-authored-by: nathanjmcdougall &lt;18602289+nathanjmcdougall@users.noreply.github.com&gt;
diff --git a/src/usethis/_file/yaml/update.py b/src/usethis/_file/yaml/update.py
@@ -64,7 +64,7 @@ def update_ruamel_yaml_map(
         cmap[key] = cmap_copy[key]
 
 
-def lcs_list_update(original: list[Any], new: list[Any]) -> None:
+def lcs_list_update(original: list[object], new: list[object]) -> None:
     """Update in-place using a longest common subsequence solver.
 
     This makes `original` identical to `new`, but respects subtypes of list such as
diff --git a/src/usethis/_pipeweld/func.py b/src/usethis/_pipeweld/func.py
@@ -252,7 +252,8 @@ def _insert_before_postrequisites(
             )
             union = _union(successor_component, self.step)
             if len(container) == 1 and container[0] == union:
-                assert union is not None
+                if union is None:
+                    raise NotImplementedError
                 component[idx + 1] = union
 
             return instructions

Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,8 @@ def _insert_before_postrequisites(`
`252`	`252`	`)`
`253`	`253`	`union = _union(successor_component, self.step)`
`254`	`254`	`if len(container) == 1 and container[0] == union:`
`255`		`- assert union is not None`
	`255`	`+ if union is None:`
	`256`	`+ raise NotImplementedError`
`256`	`257`	`component[idx + 1] = union`
`257`	`258`
`258`	`259`	`return instructions`