Refactor _is_uv_a_dep to mirror _deps.py patterns with proper types

Copilot · nathanjmcdougall · Copilot · commit 3c92360135df · 2026-03-27T10:37:19.000Z
Replace lazy import approach with architecture-compliant helpers that mirror get_project_deps()/get_dep_groups() using only _file and _types layers (permitted by import-linter). Uses TOMLDocument type, Dependency model, and packaging.requirements.Requirement for proper parsing. Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/99da146b-5070-472d-a959-ddb17f09c237 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
diff --git a/src/usethis/_backend/uv/available.py b/src/usethis/_backend/uv/available.py
@@ -1,11 +1,18 @@
 """Check whether the uv CLI is available."""
 
+from __future__ import annotations
+
+from typing import TYPE_CHECKING
+
 from packaging.requirements import InvalidRequirement, Requirement
 
 from usethis._backend.uv.call import call_uv_subprocess
 from usethis._backend.uv.errors import UVSubprocessFailedError
-from usethis._file.pyproject_toml.errors import PyprojectTOMLError
 from usethis._file.pyproject_toml.io_ import PyprojectTOMLManager
+from usethis._types.deps import Dependency
+
+if TYPE_CHECKING:
+    from tomlkit import TOMLDocument
 
 
 def is_uv_available() -> bool:
@@ -19,41 +26,76 @@ def is_uv_available() -> bool:
 
 
 def _is_uv_a_dep() -> bool:
-    """Check if uv is declared as a project dependency or in a dependency group."""
+    """Check if uv is declared as a project dependency or in a dependency group.
+
+    Note: we cannot use the higher-level ``get_project_deps`` /
+    ``get_dep_groups`` helpers from ``usethis._deps`` because the
+    ``_backend`` layer must not import from the ``_deps`` layer
+    (enforced by import-linter).  The logic below mirrors those
+    functions using only ``_file`` and ``_types`` which are
+    permitted.
+    """
+    uv_dep = Dependency(name="uv")
+
     try:
-        content = PyprojectTOMLManager().get()
-    except (FileNotFoundError, PyprojectTOMLError):
+        pyproject = PyprojectTOMLManager().get()
+    except Exception:
         return False
 
-    # Gather all requirement strings from both sources
-    req_strs: list[str] = []
+    all_deps = _get_project_deps(pyproject) + _get_dep_group_deps(pyproject)
+    return any(dep.name == uv_dep.name for dep in all_deps)
+
 
-    # Collect from project dependencies
+def _get_project_deps(pyproject: TOMLDocument) -> list[Dependency]:
+    """Extract dependencies from the [project.dependencies] section."""
     try:
-        project_section = content["project"]
-        if isinstance(project_section, dict):
-            deps = project_section["dependencies"]
-            if isinstance(deps, list):
-                req_strs.extend(s for s in deps if isinstance(s, str))
-    except (KeyError, TypeError):
-        pass
-
-    # Collect from dependency groups
+        project_section = pyproject["project"]
+    except KeyError:
+        return []
+
+    if not isinstance(project_section, dict):
+        return []
+
     try:
-        groups = content["dependency-groups"]
-        if isinstance(groups, dict):
-            for group_deps in groups.values():
-                if isinstance(group_deps, list):
-                    req_strs.extend(s for s in group_deps if isinstance(s, str))
-    except (KeyError, TypeError):
-        pass
-
-    # Check if any requirement is for 'uv'
-    for req_str in req_strs:
+        dep_section = project_section["dependencies"]
+    except KeyError:
+        return []
+
+    if not isinstance(dep_section, list):
+        return []
+
+    deps: list[Dependency] = []
+    for item in dep_section:
+        if not isinstance(item, str):
+            continue
         try:
-            if Requirement(req_str).name == "uv":
-                return True
+            req = Requirement(item)
         except InvalidRequirement:
             continue
+        deps.append(Dependency(name=req.name, extras=frozenset(req.extras)))
+    return deps
+
 
-    return False
+def _get_dep_group_deps(pyproject: TOMLDocument) -> list[Dependency]:
+    """Extract dependencies from all [dependency-groups] sections."""
+    try:
+        groups_section = pyproject["dependency-groups"]
+    except KeyError:
+        return []
+
+    if not isinstance(groups_section, dict):
+        return []
+
+    deps: list[Dependency] = []
+    for group_items in groups_section.values():
+        if not isinstance(group_items, list):
+            continue
+        for item in group_items:
+            if not isinstance(item, str):
+                continue
+            try:
+                req = Requirement(item)
+            except InvalidRequirement:
+                continue
+            deps.append(Dependency(name=req.name, extras=frozenset(req.extras)))
+    return deps
