Enable reportAttributeAccessIssue in basedpyright

nathanjmcdougall · nathanjmcdougall · commit 00ff3a47c21b · 2026-02-21T06:58:21.000+13:00
diff --git a/pyproject.toml b/pyproject.toml
@@ -210,7 +210,6 @@ failOnWarnings = true
 reportAny = false
 reportArgumentType = false
 reportAssignmentType = false
-reportAttributeAccessIssue = false
 reportCallInDefaultInitializer = false
 reportExplicitAny = false
 reportImplicitOverride = false
diff --git a/tests/usethis/_file/ini/test_ini_io_.py b/tests/usethis/_file/ini/test_ini_io_.py
@@ -103,7 +103,7 @@ def relative_path(self) -> Path:
                 change_cwd(tmp_path),
                 MyINIFileManager() as manager,
             ):
-                manager._content = 42  # type: ignore
+                manager._content = ConfigUpdater()
                 with pytest.raises(UnexpectedINIIOError):
                     manager.read_file()
 
diff --git a/tests/usethis/_file/toml/test_toml_io_.py b/tests/usethis/_file/toml/test_toml_io_.py
@@ -122,11 +122,13 @@ def relative_path(self) -> Path:
             with change_cwd(tmp_path):
                 manager = MyTOMLFileManager()
 
+            expected = tomlkit.TOMLDocument()
+
             # Act
-            manager._content = 42  # type: ignore
+            manager._content = expected
 
             # Assert
-            assert manager._content == 42
+            assert manager._content == expected
 
         def test_set_high_levels_of_nesting(self, tmp_path: Path) -> None:
             # Arrange
diff --git a/tests/usethis/_python/test_version.py b/tests/usethis/_python/test_version.py
@@ -199,12 +199,3 @@ def test_unequal_patch(self):
 
             # Act & Assert
             assert v1 != v2
-
-    class TestImmutability:
-        def test_frozen_dataclass(self):
-            # Arrange
-            version = PythonVersion(major="3", minor="13")
-
-            # Act & Assert
-            with pytest.raises(AttributeError):
-                version.major = "4"  # type: ignore[misc]
diff --git a/tests/usethis/_tool/test_base.py b/tests/usethis/_tool/test_base.py
@@ -1424,9 +1424,9 @@ def test_tool_without_selection_support(self) -> None:
             file_manager = MagicMock()
             tool = MockToolForRuleTests(file_manager=file_manager, selected_rules=[])
             # Override to simulate a tool without selection support
-            tool._get_select_keys = lambda fm: super(  # type: ignore[method-assign]
+            tool._get_select_keys = lambda file_manager: super(  # type: ignore[method-assign]
                 MockToolForRuleTests, tool
-            )._get_select_keys(fm)
+            )._get_select_keys(file_manager)
 
             # Act & Assert
             with pytest.raises(
@@ -1489,13 +1489,16 @@ def test_it_returns_false(self) -> None:
         def test_tool_without_selection_support(self) -> None:
             # Arrange
             file_manager = MagicMock()
-            tool = MockToolForRuleTests(
-                file_manager=file_manager, selected_rules=["E501"]
-            )
-            # Override to simulate a tool without selection support
-            tool._get_select_keys = lambda fm: super(  # type: ignore[method-assign]
-                MockToolForRuleTests, tool
-            )._get_select_keys(fm)
+
+            class MyMock(MockToolForRuleTests):
+                def _get_select_keys(
+                    self, file_manager: KeyValueFileManager
+                ) -> list[str]:
+                    return super(MockToolForRuleTests, self)._get_select_keys(
+                        file_manager
+                    )
+
+            tool = MyMock(file_manager=file_manager, selected_rules=["E501"])
 
             # Act & Assert
             with pytest.raises(
