feat: improved error message for ssh on invalid environment name #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Member
|
In a lot of cases, the API should handle reporting if the environment doesn't exist, for SSH this is a bit different as it doesn't use the API directly. The main difference here is that SSH portals exist, so for the CLI to know which portal endpoint to use, we have to check if the environment exists to get the portal endpoint it has associated to it. So the check to get all the environments is already done, this function does it earlier though but it means you're doing two calls to the API every time you run an SSH command. |
shreddedbacon
approved these changes
Sep 9, 2025
83cd870 to
12ee395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #457.
This PR introduces a new function
environmentCheck()that checks a given environment name string belongs to a project, and if not, returns an error with valid options that the user has access to.This PR only adds the check to the
sshcommand, but could be used for any command that mandates a project/environment input.