Skip to content

Conversation

@smlx
Copy link
Member

@smlx smlx commented Aug 27, 2024

Partially addresses #360.

Once this is merged, we can enable Dependabot at which point #360 can be closed.

@smlx smlx changed the title ci appsec Configure application security policy in CI Aug 27, 2024
@smlx smlx marked this pull request as ready for review August 27, 2024 09:31
@smlx smlx requested a review from tobybellwood August 27, 2024 09:31
@shreddedbacon shreddedbacon mentioned this pull request Oct 9, 2024
3 tasks
@shreddedbacon
Copy link
Member

shreddedbacon commented Oct 24, 2024

I've addressed all the go lint complaints now. Will leave the action stuff for someone else to address.

@smlx
Copy link
Member Author

smlx commented Oct 24, 2024

If it is easier, this can be merged without the actions changes for now. None of the checks are required - just advisory. Then at a later stage once the issues are fixed the checks can be enforced.

@shreddedbacon
Copy link
Member

If it is easier, this can be merged without the actions changes for now. None of the checks are required - just advisory. Then at a later stage once the issues are fixed the checks can be enforced.

I think just the idea of it having a constant red failure that is an advisory will still irk me. I'm happy to wait a bit to see if someone else can address the actions stuff before it annoys me too much.

@tobybellwood
Copy link
Member

I've disabled shellcheck on actions - it's very needy! We can always work on it in the background.

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to get this in place - and tweak as may be necessary!

@smlx smlx merged commit 9de912e into main Oct 25, 2024
@smlx smlx deleted the ci-appsec branch October 25, 2024 02:07
@smlx smlx mentioned this pull request Oct 25, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants