Skip to content

Revert "fix: ephemeral environment variables being saved to filesystem"#7012

Merged
bijin-bruno merged 1 commit intousebruno:mainfrom
sanjaikumar-bruno:revert-6723-refactor/ephemeral-env-vars-save-logic
Feb 2, 2026
Merged

Revert "fix: ephemeral environment variables being saved to filesystem"#7012
bijin-bruno merged 1 commit intousebruno:mainfrom
sanjaikumar-bruno:revert-6723-refactor/ephemeral-env-vars-save-logic

Conversation

@sanjaikumar-bruno
Copy link
Member

@sanjaikumar-bruno sanjaikumar-bruno commented Feb 2, 2026

Reverts #6723

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Improved environment variable persistence to retain temporary variables during save operations instead of discarding them.
    • Ensured temporary environment variables now save with their current values when no previously saved value exists.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

Walkthrough

The PR modifies ephemeral environment variable handling in save operations. Ephemeral variables without a persistedValue are now saved using their current UI value instead of being filtered out, affecting both the Redux action dispatcher and the underlying persistence utility.

Changes

Cohort / File(s) Summary
Ephemeral Variable Handling in Save Actions
packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js
Modified saveEnvironment to save ephemeral variables with UI value when no persistedValue exists, with updated documentation for persisted behavior semantics.
Environment Variable Persistence Logic
packages/bruno-app/src/utils/environments.js
Removed isPersistableEnvVarForSave filtering in save mode; buildPersistedEnvVariables now transforms all variables via toPersistedEnvVarForSave instead of filtering ephemeral vars. Merge mode behavior unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

Suggested reviewers

  • helloanoop
  • lohit-bruno
  • naman-bruno
  • bijin-bruno

Poem

🌬️ Ephemeral whispers now find their home,
No longer cast out into the foam,
When UI values dance without a trace,
They're saved to their persisted place,
One less filter, one more way to stay. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: reverting a previous fix to ephemeral environment variables handling, which aligns with the actual modifications to the save logic and variable filtering.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bijin-bruno bijin-bruno merged commit 0f0c2b5 into usebruno:main Feb 2, 2026
7 of 8 checks passed
@sanjaikumar-bruno sanjaikumar-bruno deleted the revert-6723-refactor/ephemeral-env-vars-save-logic branch February 2, 2026 12:50
@coderabbitai coderabbitai bot mentioned this pull request Feb 6, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants