add support for additional context roots in opencollection#6995
Merged
bijin-bruno merged 3 commits intousebruno:mainfrom Feb 2, 2026
Merged
add support for additional context roots in opencollection#6995bijin-bruno merged 3 commits intousebruno:mainfrom
bijin-bruno merged 3 commits intousebruno:mainfrom
Conversation
Contributor
WalkthroughAdded a new optional Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/bruno-filestore/src/formats/yml/parseCollection.ts`:
- Around line 41-48: The current assignment trusts
brunoExtensions.script.additionalContextRoots and may copy non-array values into
brunoConfig.scripts.additionalContextRoots; update the block that reads
brunoExtensions (from oc.extensions?.bruno) to first check
Array.isArray(brunoExtensions?.script?.additionalContextRoots) and then assign a
sanitized array (e.g., filter to only string values) to
brunoConfig.scripts.additionalContextRoots — only set the property when the
value is a valid string[] to avoid corrupting brunoConfig.scripts.
bijin-bruno
requested changes
Feb 1, 2026
| if (!oc.extensions.bruno) { | ||
| oc.extensions.bruno = {}; | ||
| } | ||
| (oc.extensions.bruno as any).script = { |
Collaborator
There was a problem hiding this comment.
I think this should be scripts instead of script
bijin-bruno
previously approved these changes
Feb 2, 2026
bijin-bruno
approved these changes
Feb 2, 2026
This was referenced Feb 2, 2026
5 tasks
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
Summary by CodeRabbit
Release Notes