make yml default option by naman-bruno · Pull Request #6985 · usebruno/bruno

naman-bruno · 2026-01-30T10:00:45Z

Description

Contribution Checklist:

I've used AI significantly to create this pull request
The pull request only addresses one issue or adds one feature.
The pull request does not introduce any breaking changes
I have added screenshots or gifs to help explain the change if applicable.
I have read the contribution guidelines.
Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

New Features
- Advanced Options dropdown in Create Collection to choose collection file format.
UI Updates
- Removed beta badge indicators from Share Collection and Create Collection.
- Reworked Create Collection footer layout to surface the advanced-options control.
Changes
- Default collection format changed to YAML for new collections and imports.

coderabbitai · 2026-01-30T10:01:02Z

Walkthrough

Centralized DEFAULT_COLLECTION_FORMAT = 'yml' added and replaces hardcoded 'bru' defaults across filestore, electron IPC, and app code. CreateCollection UI now conditionally shows file format via a dropdown and footer layout changed. Beta badge removed from ShareCollection and CreateCollection styles.

Changes

Cohort / File(s)	Summary
ShareCollection UI `packages/bruno-app/src/components/ShareCollection/.../StyledWrapper.js`, `packages/bruno-app/src/components/ShareCollection/index.js`	Removed beta badge styling and removed the Beta span/relative positioning from the second share option.
CreateCollection UI `packages/bruno-app/src/components/Sidebar/CreateCollection/.../StyledWrapper.js`, `packages/bruno-app/src/components/Sidebar/CreateCollection/index.js`	Removed beta-badge and discussion-link styles; added `AdvancedOptions` dropdown (forwardRef) to toggle file format visibility, replaced external-link icon with caret, reworked footer into two-sided layout.
Default Constant (app & filestore) `packages/bruno-app/src/utils/common/constants.js`, `packages/bruno-filestore/src/constants.ts`	Added exported `DEFAULT_COLLECTION_FORMAT` with value `'yml'`.
Filestore API & Workers `packages/bruno-filestore/src/index.ts`, `packages/bruno-filestore/src/workers/...`, `packages/bruno-filestore/src/workers/worker-script.ts`	Replaced hardcoded `'bru'` defaults with `DEFAULT_COLLECTION_FORMAT` in multiple public function/worker defaults; re-exported constants.
Electron IPC & Utils `packages/bruno-electron/src/ipc/collection.js`, `packages/bruno-electron/src/utils/collection-import.js`, `packages/bruno-electron/src/utils/collection.js`, `packages/bruno-electron/src/utils/parse.js`	Switched default format parameters to `DEFAULT_COLLECTION_FORMAT` and propagated import from filestore; parse functions ensure request.body fields exist after parsing.
App-level fallbacks & actions `packages/bruno-app/src/components/SaveTransientRequest/index.js`, `packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js`	Replaced hardcoded `'bru'` fallback with `DEFAULT_COLLECTION_FORMAT` when deriving filenames and in import actions.
CLI behavior `packages/bruno-cli/src/commands/run.js`	Explicitly calls `parseEnvironment` with `{ format: 'bru' }` for non-JSON/YAML env files and uses `.bru` when deriving basename for BRU files.

Sequence Diagram(s)

sequenceDiagram
    participant UI as CreateCollection UI
    participant App as Renderer (App)
    participant IPC as Electron IPC
    participant Filestore as `@usebruno/filestore`
    participant Worker as Filestore Worker

    UI->>App: user selects format / creates collection (uses DEFAULT_COLLECTION_FORMAT)
    App->>IPC: send create/import collection (format default from constant)
    IPC->>Filestore: invoke parse/stringify with format (DEFAULT_COLLECTION_FORMAT)
    Filestore->>Worker: enqueueTask / parseRequest (format forwarded)
    Worker-->>Filestore: parsed/stringified payload
    Filestore-->>IPC: result
    IPC-->>App: result
    App-->>UI: show success/failure

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

#6366 — Related changes to CreateCollection defaults and format UI.
#6784 — Related edits to CLI/environment parsing logic.
#6547 — Touches ShareCollection component; UI-related overlap.

Suggested labels

pr-feature

Suggested reviewers

helloanoop
lohit-bruno

Poem

🎀 From 'bru' to 'yml' the default takes wing,
Constants aligned, the pipelines sing,
Dropdowns reveal formats on demand,
Badges fade quietly, styles unspanned,
Code flows clearer — small cheer, big plan. ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main objective: changing the default collection format from 'bru' to 'yml' across the codebase.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

bijin-bruno

@naman-bruno
I think we have to handle additional places like

import collection
in several places in codease, we have format defaults to 'bru'. Let's put this as a constant at a common place and use in those places.
etc

coderabbitai

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

packages/bruno-electron/src/utils/parse.js (1)
3-10: ⚠️ Potential issue | 🟡 Minor

Update JSDoc to match the new default format.

The comment still says the default is 'bru', but the function now defaults to DEFAULT_COLLECTION_FORMAT ('yml').
📝 Suggested doc fix
- * `@param` {string} format - Collection format, defaults to 'bru'
+ * `@param` {string} format - Collection format, defaults to DEFAULT_COLLECTION_FORMAT ('yml')

🤖 Fix all issues with AI agents

In `@packages/bruno-filestore/src/index.ts`:
- Around line 41-46: The default format constant DEFAULT_COLLECTION_FORMAT is
'yml' but parseRequestAndRedactBody only accepts 'bru', causing an error when no
format is passed; update the default to 'bru' so the function's default matches
supported formats. Locate the DEFAULT_COLLECTION_FORMAT definition and change
its value to 'bru' (or alternatively change the function signature/default
options for parseRequestAndRedactBody to use { format: 'bru' }) so
parseRequestAndRedactBody(content, options?) will use 'bru' by default and call
bruRequestParseAndRedactBodyData without throwing.

🧹 Nitpick comments (1)

packages/bruno-app/src/components/Sidebar/CreateCollection/index.js (1)
94-106: Add a brief JSDoc for AdvancedOptions.

It’s a new abstraction; a short doc comment clarifies intent and props usage.
✍️ Suggested JSDoc
-  const AdvancedOptions = forwardRef((props, ref) => {
+  /**
+   * Advanced options dropdown trigger for the Create Collection dialog.
+   */
+  const AdvancedOptions = forwardRef((props, ref) => {
As per coding guidelines: Add JSDoc comments to abstractions for additional details.

packages/bruno-filestore/src/index.ts

bijin-bruno · 2026-02-02T04:49:48Z

packages/bruno-filestore/src/types.ts

@@ -1,5 +1,7 @@
 export type CollectionFormat = 'bru' | 'yml';

+export const DEFAULT_COLLECTION_FORMAT: CollectionFormat = 'yml';


Since this is not a type, I think we should move DEFAULT_COLLECTION_FORMAT to ./constants.ts

make yml default option

50b7ef6

naman-bruno requested review from bijin-bruno, helloanoop and lohit-bruno as code owners January 30, 2026 10:00

pull-request-size bot added the size/L label Jan 30, 2026

bijin-bruno requested changes Feb 1, 2026

View reviewed changes

fixes

f4f431e

coderabbitai bot reviewed Feb 1, 2026

View reviewed changes

packages/bruno-filestore/src/index.ts Outdated Show resolved Hide resolved

bijin-bruno requested changes Feb 2, 2026

View reviewed changes

fixes

3f92ad9

bijin-bruno previously approved these changes Feb 2, 2026

View reviewed changes

fix

4fc4392

naman-bruno dismissed bijin-bruno’s stale review via 4fc4392 February 2, 2026 10:03

bijin-bruno approved these changes Feb 2, 2026

View reviewed changes

bijin-bruno merged commit 8c997c4 into usebruno:main Feb 2, 2026
7 of 8 checks passed

coderabbitai bot mentioned this pull request Feb 20, 2026

fix: openapi cli import #7028

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make yml default option#6985

make yml default option#6985
bijin-bruno merged 4 commits intousebruno:mainfrom
naman-bruno:feat/yml-default

naman-bruno commented Jan 30, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

bijin-bruno left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

bijin-bruno Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -1,5 +1,7 @@
		export type CollectionFormat = 'bru' \| 'yml';

		export const DEFAULT_COLLECTION_FORMAT: CollectionFormat = 'yml';

Conversation

naman-bruno commented Jan 30, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contribution Checklist:

Publishing to New Package Managers

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

bijin-bruno left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bijin-bruno Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

naman-bruno commented Jan 30, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 30, 2026 •

edited

Loading